Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for drop session of same runtime #611

Closed
wants to merge 2 commits into from
Closed

test for drop session of same runtime #611

wants to merge 2 commits into from

Conversation

milyin
Copy link
Contributor

@milyin milyin commented Dec 5, 2023

Test for creating and dropping session from Runtime

@fuzzypixelz
Copy link
Member

@milyin Please change your pull request's base branch to main (new default branch). And rebase your branch against main as it is missing a status check necessary to merge this pull request but which is only available on main.

@Mallets
Copy link
Member

Mallets commented Jan 25, 2024

@milyin this PR is still marked as Draft and pointing to master. Is it relevant?

@imstevenpmwork
Copy link
Contributor

@milyin ping for Mallet's question

@milyin milyin changed the base branch from master to main March 15, 2024 10:33
@eclipse-zenoh-bot
Copy link
Contributor

@milyin If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@milyin
Copy link
Contributor Author

milyin commented Mar 15, 2024

Yes, it's relevant. This is a test for bug #612 - currently it should fail, so it doesn't make sense to merge it

@milyin
Copy link
Contributor Author

milyin commented Apr 10, 2024

The code in this PR is merged as part of #917

@milyin milyin closed this Apr 10, 2024
@milyin milyin deleted the runtime_test branch April 10, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants